Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: integration test #23

Merged
merged 3 commits into from
May 23, 2024
Merged

test: integration test #23

merged 3 commits into from
May 23, 2024

Conversation

aquariuslt
Copy link
Contributor

@aquariuslt aquariuslt commented May 17, 2024 •
edited
Loading

Change Information

  • 添加基础的集成测试

  • 修改 test.yml workflow，使其仅执行单元测试目录下的测试

  • 新增 integration-test, 执行 test/integration 下的集成测试 (时间相对更长)

  • 在集成測試目錄添加了 invariant 類測試

现在可以在测试的 workflow 日志中看到测试的 console.log 结果了

e.g. https://github.com/mest-io/mest-protocol/actions/runs/9127998534/job/25099465845?pr=23

@aquariuslt aquariuslt changed the title Test/integration test test: integration test May 17, 2024
@aquariuslt
Copy link
Contributor Author

aquariuslt commented May 17, 2024 •
edited
Loading

LCOV of commit 30c0597 during coverage #99

Summary coverage rate:
  lines......: 96.8% (180 of 186 lines)
  functions..: 96.3% (52 of 54 functions)
  branches...: 83.8% (57 of 68 branches)

Files changed coverage rate:
                                                    |Lines       |Functions  |Branches    
  Filename                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================
  contracts/lib/BondingCurveLib.sol                 |95.7%     23| 100%     2|66.7%      6

@aquariuslt aquariuslt requested a review from a team May 17, 2024 11:53
@aquariuslt
Copy link
Contributor Author

Total Coverage: 92.81%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%36

@aquariuslt aquariuslt self-assigned this May 17, 2024
@aquariuslt
Copy link
Contributor Author

Total Coverage: 92.81%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%36

@aquariuslt
Copy link
Contributor Author

Total Coverage: 92.81%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%36

@aquariuslt
Copy link
Contributor Author

Total Coverage: 92.81%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%36

0xashu
0xashu reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@0xashu 0xashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们现在单元测试已经覆盖函数级别的测试，集成测试应满足不同的上下文（也即不同 curveType, yieldAggregator）下能否正常买卖（buy/sell share），以及安全的迁移和领取 yield。

这样才能让单元测试与集成测试有所区分，集成测试更关注一系列连贯行为之后能否达到预期表现，而单元测试更多关注单一行为的表现。

@aquariuslt
Copy link
Contributor Author

我们现在单元测试已经覆盖函数级别的测试，集成测试应满足不同的上下文（也即不同 curveType, yieldAggregator）下能否正常买卖（buy/sell share），以及安全的迁移和领取 yield。

这样才能让单元测试与集成测试有所区分，集成测试更关注一系列连贯行为之后能否达到预期表现，而单元测试更多关注单一行为的表现。

正在准备这部分的case

@aquariuslt
Copy link
Contributor Author

Total Coverage: 92.81%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%36

@aquariuslt
Copy link
Contributor Author

Total Coverage: 91.67%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%36
test/integration/handlers
   BoundedIntegrationContextHandler.sol100%50%76.92%26, 26, 27, 27, 28, 28

@aquariuslt
Copy link
Contributor Author

Total Coverage: 92.22%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.45%28, 29, 29, 36

@aquariuslt
Copy link
Contributor Author

Total Coverage: 89.82%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol85.29%95%95.88%168, 168, 168, 168, 170, 170, 171, 171, 173, 173, 192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.45%28, 29, 29, 36

@aquariuslt
Copy link
Contributor Author

Total Coverage: 89.82%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol85.29%95%95.88%168, 168, 168, 168, 170, 170, 171, 171, 173, 173, 192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.45%28, 29, 29, 36

@aquariuslt
Copy link
Contributor Author

Total Coverage: 92.22%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.45%28, 29, 29, 36

@aquariuslt
Copy link
Contributor Author

Total Coverage: 89.82%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol85.29%95%95.88%168, 168, 168, 168, 170, 170, 171, 171, 173, 173, 192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.45%28, 29, 29, 36

@aquariuslt
Copy link
Contributor Author

Total Coverage: 92.22%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.45%28, 29, 29, 36

@aquariuslt
Copy link
Contributor Author

Total Coverage: 92.17%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 92.17%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 89.76%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol85.29%95%95.88%168, 168, 168, 168, 170, 170, 171, 171, 173, 173, 192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@aquariuslt aquariuslt marked this pull request as ready for review May 20, 2024 14:36
@aquariuslt
Copy link
Contributor Author

Total Coverage: 92.17%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol91.18%95%100%192, 406, 408
contracts/core/aggregator
   AaveYieldAggregator.sol50%76.92%70.37%108, 109, 109, 30, 30, 31, 31, 33, 33, 34, 34, 36, 36, 37, 37, 41, 54, 54, 62, 64, 74, 75
   BlankYieldAggregator.sol50%66.67%60%15, 15, 16, 16, 20, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 96.49%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 96.49%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 96.49%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 96.49%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 96.49%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 96.49%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 91.21%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35
test/integration/utils
   LogUtil.t.sol100%0%0%11, 11, 11, 15, 15, 15, 19, 19, 19, 23, 23, 23, 27, 27, 27, 31, 31, 31, 35, 35, 35, 39, 39, 39, 43, 43, 43, 47, 47, 47, 7, 7, 7

@aquariuslt
Copy link
Contributor Author

Total Coverage: 91.21%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35
test/integration/utils
   LogUtil.t.sol100%0%0%11, 11, 11, 111, 111, 111, 128, 128, 128, 20, 20, 20, 30, 30, 30, 41, 41, 41, 53, 53, 53, 66, 66, 66, 7, 7, 7, 80, 80, 80, 95, 95, 95

@aquariuslt
Copy link
Contributor Author

Total Coverage: 91.21%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35
test/integration/utils
   LogUtil.t.sol100%0%0%11, 11, 11, 111, 111, 111, 128, 128, 128, 20, 20, 20, 30, 30, 30, 41, 41, 41, 53, 53, 53, 66, 66, 66, 7, 7, 7, 80, 80, 80, 95, 95, 95

@aquariuslt
Copy link
Contributor Author

Total Coverage: 91.21%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35
test/integration/utils
   LogUtil.t.sol100%0%0%11, 11, 11, 111, 111, 111, 128, 128, 128, 20, 20, 20, 30, 30, 30, 41, 41, 41, 53, 53, 53, 66, 66, 66, 7, 7, 7, 80, 80, 80, 95, 95, 95

@aquariuslt
Copy link
Contributor Author

Total Coverage: 91.21%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35
test/integration/utils
   LogUtil.t.sol100%0%0%11, 11, 11, 111, 111, 111, 128, 128, 128, 20, 20, 20, 30, 30, 30, 41, 41, 41, 53, 53, 53, 66, 66, 66, 7, 7, 7, 80, 80, 80, 95, 95, 95

@aquariuslt
Copy link
Contributor Author

Total Coverage: 91.21%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35
test/lib
   LogUtil.t.sol100%0%0%11, 11, 11, 111, 111, 111, 128, 128, 128, 20, 20, 20, 30, 30, 30, 41, 41, 41, 53, 53, 53, 66, 66, 66, 7, 7, 7, 80, 80, 80, 95, 95, 95

@aquariuslt
Copy link
Contributor Author

Total Coverage: 91.21%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35
test/lib
   LogUtil.t.sol100%0%0%11, 11, 11, 111, 111, 111, 128, 128, 128, 20, 20, 20, 30, 30, 30, 41, 41, 41, 53, 53, 53, 66, 66, 66, 7, 7, 7, 80, 80, 80, 95, 95, 95

@aquariuslt
Copy link
Contributor Author

Total Coverage: 91.21%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35
test/lib
   LogUtil.t.sol100%0%0%11, 11, 11, 111, 111, 111, 128, 128, 128, 20, 20, 20, 30, 30, 30, 41, 41, 41, 53, 53, 53, 66, 66, 66, 7, 7, 7, 80, 80, 80, 95, 95, 95

@aquariuslt
Copy link
Contributor Author

Total Coverage: 91.21%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35
test/lib
   LogUtil.t.sol100%0%0%11, 11, 11, 111, 111, 111, 128, 128, 128, 20, 20, 20, 30, 30, 30, 41, 41, 41, 53, 53, 53, 66, 66, 66, 7, 7, 7, 80, 80, 80, 95, 95, 95

@aquariuslt
Copy link
Contributor Author

Total Coverage: 91.21%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35
test/lib
   LogUtil.t.sol100%0%0%11, 11, 11, 111, 111, 111, 128, 128, 128, 20, 20, 20, 30, 30, 30, 41, 41, 41, 53, 53, 53, 66, 66, 66, 7, 7, 7, 80, 80, 80, 95, 95, 95

@aquariuslt
Copy link
Contributor Author

Total Coverage: 97.08%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 97.08%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol94.12%90.48%100%396, 398
contracts/core/aggregator
   AaveYieldAggregator.sol58.33%92.31%96.30%108, 109, 109, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol83.33%100%100%35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 96.74%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol95%91.67%100%431, 433
contracts/core/aggregator
   AaveYieldAggregator.sol64.29%92.31%96.55%110, 111, 111, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@aquariuslt
Copy link
Contributor Author

Total Coverage: 96.74%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
contracts/core
   SharesERC1155.sol100%100%100%
   SharesFactoryV1.sol95%91.67%100%431, 433
contracts/core/aggregator
   AaveYieldAggregator.sol64.29%92.31%96.55%110, 111, 111, 62, 64, 74, 75
   BlankYieldAggregator.sol66.67%77.78%60%15, 15, 16, 16, 35, 35, 43, 43, 53, 55
contracts/lib
   BondingCurveLib.sol66.67%100%95.24%27, 28, 28, 35

@0xashu 0xashu merged commit c36bfa7 into value4value:dev May 23, 2024
5 checks passed
@0xashu 0xashu deleted the test/integration-test branch May 23, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SocratesLu SocratesLu SocratesLu left review comments

@0xashu 0xashu 0xashu approved these changes

Assignees
No one assigned
Labels
type: test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aquariuslt @0xashu @SocratesLu